Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not automatically backup to internal backup server if it doesn't exist #1090

Merged
merged 1 commit into from
Sep 24, 2021
Merged

Do not automatically backup to internal backup server if it doesn't exist #1090

merged 1 commit into from
Sep 24, 2021

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented Sep 24, 2021

Signed-off-by: Mykola Morhun mmorhun@redhat.com

What does this PR do?

Stops creating internal backup server and store backups on updates automatically. Does it if at least one backup server configuration is present.

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

che-incubator/chectl#1680

How to test this PR?

  1. Deploy previous version of Che.
  2. Update to a newer version
  3. Only if a backup server configuration existed, a new backup was created.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@mmorhun
Do not automatically backup to internal backup server if it doesn't e…
04057d7 
…xist

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@mmorhun mmorhun self-assigned this Sep 24, 2021
@openshift-ci openshift-ci bot added the lgtm label Sep 24, 2021
@tolusha tolusha mentioned this pull request Sep 24, 2021
Closed
29 tasks
@openshift-ci
Copy link

openshift-ci bot commented Sep 24, 2021

@mmorhun: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v7-stable-to-nightly 04057d7 link true /test v7-stable-to-nightly

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link

openshift-ci bot commented Sep 24, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, flacatus, mmorhun, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mmorhun mmorhun merged commit 7a95792 into main Sep 24, 2021
@mmorhun mmorhun deleted the do-not-automatically-backup-on-update branch September 24, 2021 14:14
@che-bot che-bot added this to the 7.37 milestone Sep 24, 2021
@tolusha tolusha mentioned this pull request Sep 27, 2021
Closed
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolusha tolusha tolusha approved these changes

@AndrienkoAleksandr AndrienkoAleksandr AndrienkoAleksandr approved these changes

@flacatus flacatus flacatus approved these changes

@nickboldt nickboldt Awaiting requested review from nickboldt

Assignees

@tolusha tolusha

@AndrienkoAleksandr AndrienkoAleksandr

@mmorhun mmorhun

Labels
lgtm
Projects
None yet
Milestone
7.37
Development

Successfully merging this pull request may close these issues.
5 participants
@mmorhun @tolusha @AndrienkoAleksandr @flacatus @che-bot